Add SEARCH_INDEX_NAME_TOPIC and SEARCH_INDEX_NAME_BOOK settings - #3529
Open
yodem wants to merge 1 commit into
Open
Add SEARCH_INDEX_NAME_TOPIC and SEARCH_INDEX_NAME_BOOK settings#3529yodem wants to merge 1 commit into
yodem wants to merge 1 commit into
Conversation
Mirrors the existing SEARCH_INDEX_NAME_TEXT/SHEET pattern so topic and book indexes can be overridden per cauldron the same way.
📊 Code Quality Score: 3/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
stevekaplan123
approved these changes
Jul 16, 2026
stevekaplan123
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEARCH_INDEX_NAME_TOPICandSEARCH_INDEX_NAME_BOOKas new overridable settings, mirroring the existingSEARCH_INDEX_NAME_TEXT/SEARCH_INDEX_NAME_SHEETpattern end-to-end.Changes
helm-chart/sefaria/values.yaml: default values ("topic"/"book"), overridable per cauldronhelm-chart/sefaria/templates/configmap/local-settings.yaml: configmap templatinghelm-chart/sefaria/templates/configmap/local-settings-file.yaml: generatedlocal_settings.pyon podssefaria/local_settings_example.py/sefaria/local_settings_ci.py: repo-side dev/CI defaultsNote: these settings live in the Helm chart's plaintext configmap values, not the SOPS-encrypted prod secret — no prod decrypt access was needed.
Shortcut: https://app.shortcut.com/sefaria/story/45621
Test plan
helm templaterenders the new configmap keys correctlylocal_settings.pyincludesSEARCH_INDEX_NAME_TOPIC/SEARCH_INDEX_NAME_BOOKwith default fallback values🤖 Generated with Claude Code