Skip to content

Add SEARCH_INDEX_NAME_TOPIC and SEARCH_INDEX_NAME_BOOK settings - #3529

Open
yodem wants to merge 1 commit into
masterfrom
feature/sc-45621/add-search-index-name-topic-book
Open

Add SEARCH_INDEX_NAME_TOPIC and SEARCH_INDEX_NAME_BOOK settings#3529
yodem wants to merge 1 commit into
masterfrom
feature/sc-45621/add-search-index-name-topic-book

Conversation

@yodem

@yodem yodem commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds SEARCH_INDEX_NAME_TOPIC and SEARCH_INDEX_NAME_BOOK as new overridable settings, mirroring the existing SEARCH_INDEX_NAME_TEXT/SEARCH_INDEX_NAME_SHEET pattern end-to-end.
  • Scaffolding only — no code currently consumes these two settings yet.

Changes

  • helm-chart/sefaria/values.yaml: default values ("topic" / "book"), overridable per cauldron
  • helm-chart/sefaria/templates/configmap/local-settings.yaml: configmap templating
  • helm-chart/sefaria/templates/configmap/local-settings-file.yaml: generated local_settings.py on pods
  • sefaria/local_settings_example.py / sefaria/local_settings_ci.py: repo-side dev/CI defaults

Note: these settings live in the Helm chart's plaintext configmap values, not the SOPS-encrypted prod secret — no prod decrypt access was needed.

Shortcut: https://app.shortcut.com/sefaria/story/45621

Test plan

  • Confirm helm template renders the new configmap keys correctly
  • Confirm a deployed pod's local_settings.py includes SEARCH_INDEX_NAME_TOPIC/SEARCH_INDEX_NAME_BOOK with default fallback values
  • Confirm per-cauldron override still works by overriding one of the new values in a values override file

🤖 Generated with Claude Code

Mirrors the existing SEARCH_INDEX_NAME_TEXT/SHEET pattern so topic and
book indexes can be overridden per cauldron the same way.
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 3/100

13 × 0.25 (Micro ESF, bumped from Nano due to 5-file breadth) = 3.25 → 3

Category Score Factors
🔭 Scope 5/20 5 files touched, all configuration, single concern (search index naming), no new APIs or endpoints
🏗️ Architecture 2/20 Pure config extension following existing pattern; no new abstractions or dependencies
⚙️ Implementation 1/20 Trivial copy-paste of existing config pattern across files; no logic or algorithms
⚠️ Risk 2/20 Additive config with safe defaults; easily reversible; no migration required
✅ Quality 3/15 No tests needed for pure config; consistent with existing patterns; example and CI files both updated
🔒 Perf / Security 0/5 No performance or security considerations for config variable additions

Was this score accurate? 👍 Yes · 👎 No

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants