Skip to content

fix(ni): a building card wears no "Interpreted" chip #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SecureCloudGroup merged 1 commit into from
Oct 14, 2026
Merged

fix(ni): a building card wears no "Interpreted" chip #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/smartbrain_3000/ni_routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,11 @@ def _board_row(store: ni.NIStore, item: dict, *,
slot = "preview" if item["state"] == "draft" else (snap.get("slot") if snap else None)
built_from = item["spec"].get("_built_from") or {}
source_type = (item["spec"].get("source") or {}).get("type")
interpreted = source_type == "model" or ni._spec_has_llm_stage(item["spec"])
# A flow SHELL (ni_flow._empty_shell_spec) carries a `model` placeholder source but has read
# nothing: no "Interpreted" chip while it builds (found 2026-10-14 recording the NI clip —
# the consent pause and an honest stop both wore the chip).
interpreted = item["spec"].get("_shell") is not True \
and (source_type == "model" or ni._spec_has_llm_stage(item["spec"]))
update_flag, gone_flag = _template_update_flags(item, library_index, library_pack_id,
spec_hashes)
row = {
Expand Down
4 changes: 4 additions & 0 deletions app/tests/test_ni_routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,6 +1204,10 @@ def test_intake_creates_shell_and_starts_worker(client: TestClient,
assert item["spec"].get("_shell") is True
entries = client.get("/api/audit").json()["entries"]
assert any(e["tool"] == "ni_intake" for e in entries)
# the shell's placeholder source is a `model` no-op that has read nothing: no "Interpreted"
# chip on the board while the card builds (2026-10-14)
row = next(r for r in client.get("/api/ni/board").json()["items"] if r["id"] == iid)
assert row["interpreted"] is False


def test_intake_duplicate_title_409s_naming_the_card(client: TestClient,
Expand Down
Loading