fix(#310): ShapeAnalysis_FreeBounds no longer crashes on disjoint free-boundary components#316
Merged
Merged
Conversation
…onnectWiresToWiresImpl WIP: carried patch + docs/test written; xcframework rebuild + Package.swift checksum still pending (placeholder checksum, will amend once the build completes). Root-caused via AddressSanitizer: ShapeAnalysis_FreeBounds's connectWiresToWiresImpl returned without assigning its owires out-parameter on empty input, leaving a null handle that later crashed NCollection_HSequence::Append with an uncatchable SIGSEGV. Minimally reproducible with two disjoint planar faces in one compound; not a data-volume threshold (150+ free-boundary loops can be fine, 2 can crash). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…h; correct test assertion Package.swift now points at the v1.12.6 release asset with the real checksum. Fixed the new regression test's freeBoundsOpenWires assertion — a valid empty compound (0 wires) is the correct post-fix result, not nil. Verified: swift build clean; OCCTShapeHealingTests (213 tests, 77 suites) and OCCTModelingTests (414 tests, 134 suites) pass, including the #263 crash-guard regression suite. The new issue310DisjointFacesFreeBounds test passes without the previous SIGSEGV. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShapeAnalysis_FreeBoundsSIGSEGVs on shapes with multiple free-boundary components, becauseconnectWiresToWiresImplleft itsowiresout-parameter uninitialized (null) on empty input, which later crashedNCollection_HSequence::Append.Scripts/patches/0004-ShapeAnalysis_FreeBounds-init-owires-empty-input-310.patch; xcframework rebuilt (all 3 slices) with it applied.Package.swiftbumped to the v1.12.6 URL + real checksum.issue310DisjointFacesFreeBounds(OCCTShapeHealingTests).CLAUDE.md's Known OCCT Bugs entry updated to record the fix.Test plan
swift build— zero errors, against the freshly rebuilt local xcframeworkswift test --filter FreeBoundsTests— 5/5 pass, including the new regression test (no crash)swift test --filter OCCTShapeHealingTests— 213 tests / 77 suites passswift test --filter OCCTModelingTests— 414 tests / 134 suites pass (no regressions from the kernel rebuild)152 closed/0 openbefore and after; tol=0.10 crashed before, now returns144 closed/0 open🤖 Generated with Claude Code