Conversation
Persist variable declarations across save, clone and import/export. Add write-only secret variables with encrypted storage, safe credential references, redaction and key rotation. Add collapsible variable cards, configured-secret badges, and a resizable sidebar with adaptive font sizes. Fix workflow editor key warnings and the model class placement required by migrations.
Register compatible Prefect deployments automatically, validate workflow bindings, protect schedule rebinding, and remove the environment deployment fallback. Add two named Prefect worker debug terminals to Full Stack with reusable second-deployment preparation and focused regression tests.
- Add WorkflowRevision, publication pointers, and schema migration - Separate drafts from published snapshots and strengthen locking and validation - Persist schedule synchronization status and support retries - Add legacy snapshot import and adapt secret rotation to database revisions - Remove legacy flows placeholders and add upgrade docs and regression tests Validation: 81 tests passed; migration consistency check passed
alexchen16
requested changes
Sep 26, 2026
alexchen16
left a comment
Contributor
There was a problem hiding this comment.
[P0] GitHub 当前 mergeable=false,技术上不能直接合并到 main
影响:GitHub 当前 PR metadata 显示 mergeable=false。无论代码质量如何,现状都必须先 rebase/merge main 并解决冲突,再重新跑完整测试。
证据 / 关键代码:
PR #55
base: main
head: feature/workflow
mergeable: false
changed_files: 66
+4798 / -734
建议:先更新 main 到该分支并解决冲突;冲突解决后重新审查重叠文件,特别是 workflows/*、frontend workflow editor,以及与 #52/#53 可能重叠的文件。随后重新跑 backend、frontend、migration、smoke test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add reusable workflow variables, explicit Prefect deployment routing, and database-backed publication snapshots. Workflow edits remain separate from published definitions, while execution and historical callbacks retain their selected versions.
Changes
PREFECT_DEPLOYMENT_IDfallback.WorkflowRevision, with a current-publication pointer, atomic version allocation, and transaction locking.Upgrade and compatibility
0011through0014.sync_prefect_schedulesafter migration.manifest_refandmanifest_filenameare logical identifiers, and the deprecatedmanifest_pathis empty.See
docs/workflow-deployments.zh-CN.mdandbackend/workflows/README.mdfor rollout instructions.Validation