Skip to content

Milestone 3: verified citation grounding - #4

Merged
Sebastiangmz merged 7 commits into
mainfrom
feat/m3-verified-citations
Jun 28, 2026
Merged

Sebastiangmz merged 7 commits into
mainfrom
feat/m3-verified-citations

Conversation

@Sebastiangmz

Copy link
Copy Markdown
Owner

Summary

  • add deterministic citation verification against the current retrieved evidence set
  • make Response.grounded depend on all parsed citations verifying
  • expose citation verification through REST, MCP, CLI, and UI status text
  • add M3 EvalFly and CI validation gates

Verification

  • bun run /Users/sebastian/.omp/omp-pantheon/skills/specsafe/bin/specsafe.ts status -> no slice open, 6 history entries
  • PYTHONPATH=src .venv/bin/python -m pytest tests/test_citations.py tests/test_m3_citations.py tests/test_api_routes.py tests/test_mcp_handlers.py tests/test_ui_handlers.py -> 45 passed
  • .venv/bin/python -m ruff check ... -> OK
  • PYTHONPATH=src .venv/bin/mypy ... -> OK
  • .venv/bin/python scripts/evalfly_smoke.py --suite smoke -> evalfly committed smoke passed: 15 cases
  • .venv/bin/python -m py_compile ... -> exit 0
  • .venv/bin/python -m build -> built sdist and wheel
  • PYTHONPATH=src .venv/bin/python -m pytest tests/test_m0_baseline.py tests/test_m1_services.py tests/test_m2_registry.py tests/test_citations.py tests/test_m3_citations.py tests/test_api_routes.py tests/test_mcp_handlers.py tests/test_mcp_tools.py tests/test_ui_handlers.py -> 84 passed

Review

  • M3ReReview verdict: APPROVE
  • prior P1 fixed: MCP citations are JSON-safe and CLI JSON consumes serialized payloads

Spec-Slice: CRAG-20260628-M3-VERIFIED-CITATIONS

Spec-Slice: CRAG-20260628-M3-VERIFIED-CITATIONS
Spec-Slice: CRAG-20260628-M3-VERIFIED-CITATIONS
Spec-Slice: CRAG-20260628-M3-VERIFIED-CITATIONS
Spec-Slice: CRAG-20260628-M3-VERIFIED-CITATIONS
Spec-Slice: CRAG-20260628-M3-VERIFIED-CITATIONS
Spec-Slice: CRAG-20260628-M3-VERIFIED-CITATIONS
Copilot AI review requested due to automatic review settings June 28, 2026 04:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Spec-Slice: CRAG-20260628-M3-VERIFIED-CITATIONS
@Sebastiangmz
Sebastiangmz merged commit f8c660a into main Jun 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants