Manual Move Undo and Human vs Human Mode: See #202 #204#305
Open
dudecon wants to merge 6 commits intoSebLague:mainfrom
Open
Manual Move Undo and Human vs Human Mode: See #202 #204#305dudecon wants to merge 6 commits intoSebLague:mainfrom
dudecon wants to merge 6 commits intoSebLague:mainfrom
Conversation
add human vs human button
To-Do: Update board highlighting Debug both players able to move on undo, resulting in possible illegal moves Debug multi-undo soft lock when first player is bot.
Fixed board highlighting Fixed multi-undo soft lock when first player is bot. Fixed both human players able to move on undo
dudecon
changed the title
VitorA29
added a commit
to VitorA29/Chess-Challenge
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #204 with a new manual undo button at the top of the button UI
Also implements #202 human vs human with thanks to @harrisi
Both features are implemented together since undo rolls back 1 move in HvH, and 2 moves in HvB (the bot's last move, and the human's last move).
Currently does not refund the thinkDuration spent calculating moves, since bots can cache calculation results. If refund is desired, we should probably store the think duration in the Move objects.