fix: Dashboard crashes with blank white screen — systems.filter is not a function#905
Open
Pcmhacker-piro wants to merge 1 commit into
Open
Conversation
…t a function
Root cause: ensureListResponse in api.ts returned the full paginated object
{ items, total, skip, limit } instead of extracting the items array.
Consumers then tried to call .filter() on the paginated object instead of
the items array, causing a TypeError.
Fix: ensureListResponse now always returns T[] by unwrapping data.items
when the response is a paginated object. This ensures all consumers
(AISystems, Dashboard, Documents) consistently receive a plain array
from aiSystemsApi.list() and documentsApi.list().
Closes SdSarthak#309
Author
|
Hi, the checks have passed. Could you please review and approve the pending workflows when you have a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Dashboard crash caused by calling .filter() on a paginated response object instead of the items array. The root cause was in ensureListResponse in api.ts which returned the full paginated wrapper { items, total, skip, limit } instead of extracting the items array.
Closes #309
Type of Change
Checklist
Root Cause
The backend returns a paginated response: { items: [], total: 0, skip: 0, limit: 50 }. The ensureListResponse function in api.ts passed through the entire object instead of extracting .items. Consumers like Dashboard.tsx, Documents.tsx, and AISystems.tsx used the pattern Array.isArray(data) ? data : (data?.items ?? []) to handle both formats, but if the fallback was triggered on the paginated wrapper, the object itself was assigned to the variable — causing .filter() to throw "systems.filter is not a function".
Fix
CHANGED FILES
COMMITS
d47fd58 - fix: Dashboard crashes with blank white screen — systems.filter is not a function
TESTING PERFORMED
N/A (frontend lint/build tools not available locally; CI runs lint on push via GitHub Actions)
FINAL STATUS