fix: require .trained marker to load classifier, preventing use of ra…#904
Open
Pcmhacker-piro wants to merge 1 commit into
Open
fix: require .trained marker to load classifier, preventing use of ra…#904Pcmhacker-piro wants to merge 1 commit into
Pcmhacker-piro wants to merge 1 commit into
Conversation
…ndom stub weights
Author
|
hyy @SdSarthak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #335
The IntentClassifier's _has_trained_weights method only checked for the existence of weight files (pytorch_model.bin/model.safetensors), but did not verify the model was actually fine-tuned. This allowed random stub models (e.g., from download_model.py) to be loaded for inference, producing unreliable prompt injection detection.
The fix introduces a .trained marker file that the training pipeline creates after fine-tuning completes. The classifier now requires this marker to exist alongside the weight files before loading the model as a fine-tuned classifier. Without it, the system falls back to the deterministic heuristic classifier.
Type of Change
Checklist
CHANGED FILES
COMMITS
67187e9 - fix: require .trained marker to load classifier, preventing use of random stub weights
TESTING PERFORMED
git diff --stat
3 files changed, 44 insertions(+), 6 deletions(-)
FINAL STATUS