Skip to content

fix: set company placeholder to UNKNOWN and normalize priority to uppercase#894

Open
Pcmhacker-piro wants to merge 1 commit into
SdSarthak:mainfrom
Pcmhacker-piro:fix/slack-notifier-company-placeholder
Open

fix: set company placeholder to UNKNOWN and normalize priority to uppercase#894
Pcmhacker-piro wants to merge 1 commit into
SdSarthak:mainfrom
Pcmhacker-piro:fix/slack-notifier-company-placeholder

Conversation

@Pcmhacker-piro
Copy link
Copy Markdown

@Pcmhacker-piro Pcmhacker-piro commented Jun 1, 2026

📝 Use this PR Body:

Closes #686

## Problem
`build_slack_payload()` used `"Unknown"` (mixed case) as the fallback
for the company field, but tests expect `"UNKNOWN"` (uppercase).
Priority values were also not normalized, causing inconsistent casing.

## Fix
- Company fallback changed to `"UNKNOWN"` (uppercase)
- Priority normalized via `.upper()` to handle any input casing

## File Changed
- `backend/services/slack_notifier.py`

## Tests
✅ 338 passed, 1 skipped — all existing tests pass

──────

Why this matters:

• Title tells the maintainer exactly what was fixed at a glance
• "Closes #686" in the body automatically links and closes the issue when merged
• Test results show your change doesn't break anything

@Pcmhacker-piro
Copy link
Copy Markdown
Author

@SdSarthak

Hi, the checks have passed. Could you please review and approve the pending workflows when you have a chance? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Slack notifier company placeholder case

1 participant