Skip to content

fix: replace skip with page param in ai systems pagination#891

Open
Pcmhacker-piro wants to merge 1 commit into
SdSarthak:mainfrom
Pcmhacker-piro:fix/pagination-skip-to-page
Open

fix: replace skip with page param in ai systems pagination#891
Pcmhacker-piro wants to merge 1 commit into
SdSarthak:mainfrom
Pcmhacker-piro:fix/pagination-skip-to-page

Conversation

@Pcmhacker-piro
Copy link
Copy Markdown

Summary

Closes #588

Frontend was sending skip but the backend GET /ai-systems/ endpoint expects page (1-indexed). Replaced skip: (currentPage - 1) * limit with page: currentPage in AISystems.tsx and the corresponding type in api.ts.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • Tests
  • Infra / CI

Checklist

  • I have read CONTRIBUTING.md
  • My code follows the project style (PEP 8 for Python, ESLint for TS)
  • I have added/updated tests where relevant
  • pytest backend/tests/ passes locally
  • I have not committed .env or any secrets
  • I have updated documentation if needed

Screenshots (if UI change)

N/A — backend parameter name change only.

@Pcmhacker-piro
Copy link
Copy Markdown
Author

hii @SdSarthak

the checks have passed. Could you please review and approve the pending workflows when you have a chance? Thank you!

@Pcmhacker-piro
Copy link
Copy Markdown
Author

hii @SdSarthak
the checks have passed. Could you please review and approve the pending workflows when you have a chance? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Pagination broken in AI Systems — frontend sends skip but backend expects page

1 participant