fix: serialize FAISS index rebuilds with lock and atomic swap#886
Open
Pcmhacker-piro wants to merge 1 commit into
Open
fix: serialize FAISS index rebuilds with lock and atomic swap#886Pcmhacker-piro wants to merge 1 commit into
Pcmhacker-piro wants to merge 1 commit into
Conversation
Author
|
hii @SdSarthak the checks have passed. Could you please review and approve the pending workflows when you have a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #761
Serializes concurrent FAISS index rebuilds so that overlapping
/rag/ingestrequests cannot overwrite each other or leave a partially-written index for readers. A process-levelthreading.Lockguards the rebuild path, the index is built in a temporary directory (never touching the live path), validated by reloading, then atomically swapped intosettings.FAISS_INDEX_PATHviashutil.move.Type of Change
Checklist
pytest backend/tests/passes locally.envor any secretsEdge Cases Handled
_rag_index_lockserializes rebuilds — second request waits, never overwritesshutil.moveis atomic on same filesystem — reader gets old or new, never partialFAISS.load_local()validates before swap — raises, temp dir is cleaned up, live index untouchedos.path.existscheck skipped,shutil.movecreates the live path freshTemporaryDirectorycontext manager removes staged path automatically (no-op if already moved)tempfile.gettempdir()is same filesystem as CWD on standard Linux/macOS setups;shutil.movefalls back to copy+delete if neededScreenshots (if UI change)
Not applicable; backend reliability fix.