security: enforce stricter input validation for #830#859
Open
basantnema31 wants to merge 1 commit into
Open
Conversation
SdSarthak
requested changes
May 31, 2026
Owner
SdSarthak
left a comment
There was a problem hiding this comment.
The sanitizeInput utility is a one-liner regex that strips HTML tags but it's not wired to anything in the codebase — no forms, inputs, or API boundaries use it.
If this is meant to prevent XSS, the right approach is to use DOMPurify for sanitizing HTML content in the DocumentEditor preview (which renders raw markdown/HTML), not a regex on all inputs. Regex-based HTML stripping is not safe against all XSS vectors.
Please either:
- Wire the validation to the components that actually need it (e.g., the document preview) with a proper sanitization library, or
- Describe what specific vulnerability this fixes and where it's applied.
0690f79 to
c7ebc4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #830.