🎨 Palette: Add progressive character limit warnings#170
Conversation
Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cabaa422b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {alternativeThought.length} / 300 characters | ||
| </div> | ||
| {alternativeThought.length >= 240 && alternativeThought.length < 270 && ( | ||
| <div role="status" className="sr-only">Approaching character limit</div> |
There was a problem hiding this comment.
Keep the live region mounted before updating it
For screen-reader users crossing the 80%, 90%, or 100% thresholds, these role="status" nodes are inserted already containing their final text, and many assistive-tech stacks only announce changes inside an existing live region rather than initial content on a newly mounted non-alert region. The warning can therefore be silent in the exact accessibility path this change adds; keep one hidden status region mounted and update its text when the threshold bucket changes.
Useful? React with 👍 / 👎.
💡 What: Replaced the static character counter on the
alternativeThoughttextarea with a dynamic one that provides progressive visual feedback (turns orange at 80% capacity and red at 90% capacity).🎯 Why: To provide users with clear, intuitive feedback about how close they are to the 300-character limit, reducing friction and preventing unexpected cut-offs during data entry.
📸 Before/After: The counter text color progresses from gray to orange to red.
♿ Accessibility: Added conditional, visually hidden
role="status"elements that mount at specific thresholds (80%, 90%, 100%) to provide static screen reader warnings without announcing every single keystroke.PR created automatically by Jules for task 3735551552001129789 started by @Sczitzo