🎨 Palette: Replace native confirm dialog with accessible soft confirmation#168
🎨 Palette: Replace native confirm dialog with accessible soft confirmation#168Sczitzo wants to merge 1 commit into
Conversation
…ation Extracted the blocking `window.confirm()` dialog in the SessionConsole "End Session" action and replaced it with a safe, state-based inline soft confirmation. This preserves the warning text for screen readers using `role="status"` and provides an explicit "Cancel" button to back out safely, improving the overall UX and accessibility of destructive actions. Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60c2eeb376
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <button | ||
| onClick={handleEndSession} | ||
| className="flex-1 px-4 py-2 bg-red-600 text-white rounded-lg hover:bg-red-700 focus-visible-ring" | ||
| > | ||
| Confirm End |
There was a problem hiding this comment.
When a user rapidly double-clicks the original End Session button, the first click sets isConfirmingEnd and immediately replaces it with this Confirm End button in the same row; the second click can then land on the new button and emit endSession without a deliberate confirmation. Because ending a session generates the summary and closes the session, please make the confirm step require a separate gesture that cannot be satisfied by the same double-click, such as deferring/enabling the confirm action after the initial click or rendering it away from the original click target.
Useful? React with 👍 / 👎.
1 participant
💡 What: Replaced the blocking native
window.confirm()dialog for the "End Session" action with a state-based inline soft confirmation. Added "Confirm End" and "Cancel" buttons, and preserved the contextual warning text rendered dynamically withrole="status".🎯 Why: Native confirm dialogs are visually jarring, inaccessible by default, and break the flow of the application. An inline soft confirmation is much smoother, explicitly prevents accidental permanent closure of sessions, and provides better screen-reader support for the contextual warning.
📸 Before/After: Before: Clicking "End Session" popped a browser-native modal. After: Clicking "End Session" safely expands the row to reveal "Confirm End" (red), "Cancel" (gray), and a helpful red warning text below.
♿ Accessibility: The contextual warning text detailing the consequence of ending the session is rendered dynamically into the DOM using
role="status", ensuring screen readers reliably announce the warning when the user activates the first phase of the destructive action.PR created automatically by Jules for task 11786387393984060779 started by @Sczitzo