🎨 Palette: Add dynamic character limit warning#167
Conversation
…sponseForm and improves accessibility for screen readers. Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a748051b24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {alternativeThought.length} / 300 characters | ||
| </div> | ||
| {alternativeThought.length >= 240 && alternativeThought.length < 300 && ( | ||
| <div role="status" className="sr-only"> |
There was a problem hiding this comment.
For screen-reader users who type or paste past the 240-character threshold, this role="status" node is conditionally mounted already containing the warning text. Polite live regions are only reliably announced when the contents of an existing region change, so the new “Approaching character limit” message can be silent instead of providing the intended warning; keep a persistent sr-only status region in the DOM and update its text as the threshold changes.
Useful? React with 👍 / 👎.
1 participant
💡 What: Added dynamic visual feedback (color changes) to the character limit counter on the Alternative Thought input, and added a screen-reader-friendly warning when approaching the limit.
🎯 Why: Users need clear, non-intrusive feedback when they are getting close to a character limit to adjust their writing accordingly. Sighted users get color cues, while screen reader users get a single timely announcement rather than noisy updates.
📸 Before/After: Visual changes to character count color.
♿ Accessibility: Added a visually hidden
role="status"element that announces statically when the user is approaching the character limit, avoiding the noise of anaria-liveelement on the raw character count.PR created automatically by Jules for task 2530417273722777295 started by @Sczitzo