Skip to content

🎨 Palette: Replace native confirm dialog with accessible soft confirmation#166

Open
Sczitzo wants to merge 1 commit into
mainfrom
palette-accessible-soft-confirm-2200031832092286297
Open

🎨 Palette: Replace native confirm dialog with accessible soft confirmation#166
Sczitzo wants to merge 1 commit into
mainfrom
palette-accessible-soft-confirm-2200031832092286297

Conversation

@Sczitzo

@Sczitzo Sczitzo commented Jul 3, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced the native blocking window.confirm() dialog for the 'End Session' action in SessionConsole.tsx with an inline, state-based soft confirmation UI.

🎯 Why: Native browser confirm() dialogs are generally considered poor UX because they block the main thread, cannot be consistently styled across browsers/devices, and can sometimes be confusing for users with screen readers. The soft confirmation provides a much cleaner, integrated experience while still protecting users from accidental destructive actions.

📸 Before/After:
Before: Clicking 'End Session' triggered an unstyled native browser modal popup with "OK" and "Cancel".
After: Clicking 'End Session' dynamically transforms the button area into an inline layout with styled 'Confirm End' (red) and 'Cancel' (gray) buttons, along with a warning text below them.

Accessibility:

  • Added role="status" to the conditionally rendered warning text ("⚠️ This will generate the session summary."). This ensures that when the user clicks 'End Session', their screen reader immediately announces the consequence of the impending destructive action, preserving the context that was previously provided by the native confirm dialog.
  • Maintained clear visual focus states (focus-visible-ring) on both the confirm and cancel buttons.

PR created automatically by Jules for task 2200031832092286297 started by @Sczitzo

Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 848b3d4044

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +95 to +97
<button
onClick={handleEndSession}
className="flex-1 px-4 py-2 bg-red-700 text-white font-bold rounded-lg hover:bg-red-800 focus-visible-ring"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prevent double-clicks from confirming the end

When a facilitator double-clicks the left side of the original End Session button, the first click sets showEndConfirm, React can render these inline controls before the second click, and the second click lands on Confirm End, immediately emitting endSession. That makes a common accidental double-click bypass the confirmation step that the previous native dialog enforced, which is risky because ending a session generates the summary and transitions the session to ENDED.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant