🎨 Palette: Replace native confirm dialog with accessible state-based soft confirmation#163
🎨 Palette: Replace native confirm dialog with accessible state-based soft confirmation#163Sczitzo wants to merge 1 commit into
Conversation
…mation Replaced the blocking, unstyled native `window.confirm()` in SessionConsole.tsx with an inline, state-based soft confirmation to improve UX. Added 'Cancel' and 'Confirm End' buttons, along with a `role="status"` warning message to maintain Section 508 compliance and ensure screen readers announce the action's consequences. Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8975b3bb9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (showEndConfirm) { | ||
| socket.emit('facilitator', { | ||
| type: 'endSession', | ||
| payload: { sessionId }, | ||
| }); |
There was a problem hiding this comment.
When the inline Confirm End button is double-clicked before the sessionState.status broadcast changes to ENDED, each click enters this branch and emits another endSession. The server handler creates a SessionSummary for the same session, and prisma/schema.prisma makes SessionSummary.sessionId unique, so the second emit can regenerate the summary work and then throw a duplicate-key error; the previous native dialog required a separate confirmation for each emit. Consider setting a pending/reset state or disabling the button immediately after the first confirmed click.
Useful? React with 👍 / 👎.
1 participant
window.confirm()dialog for ending a session with an inline, state-based soft confirmation UI.role="status"to the warning text to ensure screen readers explicitly announce the consequences of the destructive action when the confirmation state is triggered. The side-by-side layout ensures keyboard users are not trapped.PR created automatically by Jules for task 11353700967053936361 started by @Sczitzo