🎨 Palette: Add progressive visual and accessible feedback to character counter#156
🎨 Palette: Add progressive visual and accessible feedback to character counter#156Sczitzo wants to merge 1 commit into
Conversation
…r counter - Adds dynamic color warnings (orange at 80%, red at 90%) to the character counter in `ResponseForm.tsx`. - Implements visually hidden, static status elements for screen reader announcements at these milestones to avoid noisy `aria-live` keystroke announcements. - Logs learning to `.Jules/palette.md`. Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b3f953c1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {alternativeThought.length >= 240 && alternativeThought.length < 300 && ( | ||
| <div role="status" className="sr-only"> | ||
| Approaching limit |
There was a problem hiding this comment.
When the user types or pastes from below the threshold to 240 characters, the live region is created already containing Approaching limit; many screen-reader/browser combinations only announce changes inside an existing live region, not the initial contents of a newly inserted role="status" node. That means the warning this change is meant to add can be missed at both the 240- and 300-character milestones. Keep one visually hidden status region mounted and update its text when a milestone is reached.
Useful? React with 👍 / 👎.
1 participant
💡 What: Added progressive visual feedback (colors) and accessible screen reader milestones to the character limit counter on the "Alternative Thought" textarea.
🎯 Why: To clearly indicate when a user is approaching the 300-character limit, without creating a frustratingly noisy experience for screen reader users (which happens if
aria-liveis applied directly to a dynamically updating number).📸 Before/After: The counter text now turns orange at 240 characters and red at 270 characters. Screen readers receive a static "Approaching limit" warning at 240 characters and "Character limit reached" at 300 characters.
♿ Accessibility: Improved screen reader experience by using conditionally rendered
<div role="status" className="sr-only">elements instead of a noisyaria-liveattribute on the changing counter value.PR created automatically by Jules for task 4529652162950881722 started by @Sczitzo