🎨 Palette: Replace window.confirm with state-based soft confirmation for End Session#155
🎨 Palette: Replace window.confirm with state-based soft confirmation for End Session#155Sczitzo wants to merge 1 commit into
Conversation
…for End Session Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Replaced the thread-blocking
window.confirm()native browser dialog in the "End Session" workflow with an inline, state-based soft confirmation UI.🎯 Why:
Native browser alerts block the main thread, visually disrupt the user context, and are generally jarring UX. A state-based confirmation keeps the user within the flow of the application and provides a more modern, integrated feel while still preventing accidental session terminations.
📸 Before/After:
Before: Clicking "End Session" triggered a system-level popup.
After: Clicking "End Session" transitions the button area into a red confirmation zone with explicit "Cancel" and "Confirm End" buttons, retaining the warning text about generating the session summary.
♿ Accessibility:
Ensured the warning text ("This will generate the session summary.") is rendered inside a paragraph with
role="status"so that screen readers will reliably and automatically announce the critical consequence of the destructive action when the confirmation state toggles on. Included focus-visible styling on the new buttons for keyboard navigation.PR created automatically by Jules for task 18136600904094008325 started by @Sczitzo