🎨 Palette: Add accessible character limit feedback to ResponseForm#152
🎨 Palette: Add accessible character limit feedback to ResponseForm#152Sczitzo wants to merge 1 commit into
Conversation
Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 463506ab91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {alternativeThought.length >= 240 && alternativeThought.length < 300 && ( | ||
| <div role="status" className="sr-only">Approaching character limit</div> | ||
| )} | ||
| {alternativeThought.length >= 300 && ( | ||
| <div role="status" className="sr-only">Character limit reached</div> |
There was a problem hiding this comment.
When a screen-reader user types from 239 to 240 characters, this creates a new role="status" node that already contains the warning text. AT/browser combinations that only announce updates to a pre-existing live region can miss that insertion, so the new character-limit warning may not be announced at all. Keep a persistent sr-only status element in the DOM and update its text when the thresholds are crossed.
Useful? React with 👍 / 👎.
1 participant
💡 What: Added accessible screen-reader warnings and progressive visual feedback (orange, then red text) to the
alternativeThoughtcharacter counter.🎯 Why: Character counters that use
aria-liveor announce on every keystroke are incredibly noisy and frustrating for screen reader users. This update silences the visual counter from screen readers and instead conditionally renders staticrole="status"warnings only when approaching (80%) or reaching (100%) the limit.📸 Before/After: The character counter text turns orange at 240/300 characters, and bold red at 270/300 characters.
♿ Accessibility: The character counter itself is now
aria-hidden="true", preventing keystroke spam. Screen readers now instead announce "Approaching character limit" at 240 characters, and "Character limit reached" exactly at 300 characters.PR created automatically by Jules for task 536584041901048329 started by @Sczitzo