🎨 Palette: Accessible soft confirmation for session end#151
Conversation
- Replaced native `window.confirm()` with a 2-step inline soft confirmation in `SessionConsole.tsx`. - Added a Cancel button to allow users to back out of the confirmation state. - Extracted the confirmation warning into a `role="status"` element so screen readers reliably announce the consequences. - Updated journal with learnings. Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be11672965
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div className="flex gap-2"> | ||
| <button | ||
| onClick={handleEndSession} | ||
| className="flex-1 px-4 py-2 bg-red-50 border-2 border-red-500 text-red-600 hover:bg-red-500 hover:text-white rounded-lg focus-visible-ring transition-colors duration-200" |
There was a problem hiding this comment.
When the confirm button is hovered, this class changes the label to white text on Tailwind red-500; at the default button text size that combination is only about 3.8:1 contrast, below the 4.5:1 WCAG AA threshold for normal text. This affects low-vision users exactly while they are deciding whether to confirm the destructive end-session action, so the hover state should use a darker red such as red-600/red-700 or keep the text dark.
Useful? React with 👍 / 👎.
1 participant
💡 What: Replaced the native
window.confirmmodal with an inline soft confirmation for ending sessions, including a "Cancel" button to back out.🎯 Why: To create a safer, less intrusive UX that doesn't block the browser while still preventing accidental session ends.
📸 Before/After: Before it used a blocking browser confirm dialog. After it uses a 2-step inline UI with confirm and cancel buttons.
♿ Accessibility: Extracted the confirmation warning into a
role="status"element so screen readers reliably announce the consequences without needing an alert dialog.PR created automatically by Jules for task 6291393720933112751 started by @Sczitzo