🎨 Palette: Progressive character limit feedback and semantic labeling#147
🎨 Palette: Progressive character limit feedback and semantic labeling#147Sczitzo wants to merge 1 commit into
Conversation
Co-authored-by: Sczitzo <46541128+Sczitzo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5811ab0a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {alternativeThought.length >= 240 && alternativeThought.length < 300 && ( | ||
| <div role="status" className="sr-only">Approaching character limit</div> |
There was a problem hiding this comment.
Announce the critical limit threshold
When a user types from 240 to 299 characters, this condition keeps the same role="status" node and text mounted. The visual state changes to red/bold at 270, but assistive technology only gets the earlier generic “Approaching character limit” announcement and no critical/90% warning until the hard 300-character limit, so the new progressive feedback is visual-only for screen-reader users. Consider changing the status text or condition at >=270 so the critical threshold is announced.
Useful? React with 👍 / 👎.
💡 What: Implemented progressive visual feedback (orange warning at 80%, red critical at 90%) for the
alternativeThoughtcharacter limit. Also removed a redundantaria-describedbyattribute on theautomaticThoughtinput.🎯 Why: The previous character counter was static, providing no visual indication as the user approached the limit. Adding a visually hidden status element ensures screen reader users receive timely warnings without constant noisy updates. Additionally, the redundant
aria-describedbycaused double announcements for the "(Optional)" label text.📸 Before/After:
Before: Static counter (
text-gray-500) regardless of character count. Redundantaria-describedbyannouncing "Optional" twice.After: Counter turns orange at 240/300 characters, red and bold at 270/300 characters. Screen readers receive a single announcement for the "Optional" label.
♿ Accessibility: Added conditional
<div role="status" className="sr-only">elements at critical thresholds for character count warnings instead of usingaria-liveon the rapidly changing count text. Fixed duplicate reading of theautomaticThoughthint text by removing the unnecessaryaria-describedby.PR created automatically by Jules for task 6457099640941360011 started by @Sczitzo