fix: allowlist credential URLs, block fetch redirects, harden error redaction - #15
Open
lewismarshall wants to merge 1 commit into
Open
Conversation
Validate gateway/backend hosts before sending tokens, set redirect:error on both fetch sites, and redact secrets in error output more thoroughly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops sending the live gateway / EnsureSandBox bearer token to unexpected hosts or across HTTP redirects, and hardens stderr redaction so error bodies are less likely to leak credentials.
Changes
src/url-policy.js)httpsonly on*.cursor.sh/*.cursor.com(and apex).GROK_BOT_ALLOW_LOCAL_GATEWAY=1forhttp(s)://127.0.0.1,localhost,::1.GROK_BOT_ALLOW_ANY_GATEWAY=1break-glass (documented as unsafe).gatewayCall.redirect: "error"on bothfetchsites (ensureSandbox,gatewayCall).redactSecrets()infail()and gateway error paths (broader than the old Bearer-only regex).Test plan
npm test(includes newtest/url-policy.test.js)gbot bots listGROK_BOT_ALLOW_LOCAL_GATEWAY=1with local gatewayNotes for maintainers
If production box gateway hosts are not under
*.cursor.sh/*.cursor.com, please say so in review and we can extend the allowlist before merge (or document the required env opt-in).