feat: add polls feature by ap-1 · Pull Request #148 · ScottyLabs/dalmatian

ap-1 · 2026-04-10T18:44:14Z

Adds /poll command with six subcommands:

setup (configure guild polls channel)
create (create a poll with up to 10 options, optional multi-select)
results (view vote counts)
delete (for admins or poll authors to remove polls)
close (to manually close the poll before expiry)
myvote (check your own vote on an anonymous poll)

Closes https://github.com/ScottyLabs/dalmatian/issues/48

maybe-yiyi · 2026-04-13T20:29:28Z

just some things, not sure if some are feasible at all

Should we have polls autoclose? What if people just want the polls to be open indefinitely?
I think the results page should reference the original poll perhaps
- is there a way to make it so you can see your own vote on anonymous polls? obviously we wouldn't be able to use ephemeral messages for that
For me the polls are saying Poll by <@649388957007609879>•Today at 16:21 instead of mentioning the user
i think we should put at least rolling counts on the ongoing polls
does the poll embed builder just add every single voter to the voting list? it feels like you might hit embed limits on massive polls, and/or it crowds the answer choices
what if i want to unvote from a poll

ap-1 · 2026-04-13T20:48:06Z

just some things, not sure if some are feasible at all

* Should we have polls autoclose? What if people just want the polls to be open indefinitely?

* I think the results page should reference the original poll perhaps
  
  * is there a way to make it so you can see your own vote on anonymous polls? obviously we wouldn't be able to use ephemeral messages for that

* For me the polls are saying `Poll by <@649388957007609879>•Today at 16:21` instead of mentioning the user

* i think we should put at least rolling counts on the ongoing polls

* does the poll embed builder just add every single voter to the voting list? it feels like you might hit embed limits on massive polls, and/or it crowds the answer choices

* what if i want to unvote from a poll

made duration optional so there's no expiry by default
results embed links to the original poll message
/poll myvote to check your vote on anonymous polls
"Poll by" moved from footer to description
rolling vote counts shown on ongoing poll embeds now
voter list capped at 10 with "+ X more"
allows unvoting now by removing the minimum selected values

maybe-yiyi · 2026-04-13T20:53:02Z

wait how do you unvote
it doesn't seem like i'm able to send a selection with 0 options selected or anything

ap-1 · 2026-04-13T20:59:38Z

nevermind seems like that's not a thing, i just added an unvote button instead

maybe-yiyi

besides these things lgtm

didn't test attempting to delete polls without being the author, but the code looks correct.

perhaps eventually we can whitelist/blacklist multiple roles
maybe we consider whether it's necessary to enumerate the poll options, since we aren't voting using the enumeration nor does it really matter for poll results?

maybe-yiyi

great, thanks!

perhaps @TenType will want to review in terms of design, but it looks good to me.

TenType

I'll check this as well tonight, thanks yiyoung!

TenType

looks good, some things I think we should change:

I'd prefer if we don't show who votes for what by default as it clutters the embed. maybe we can have a button "See voters" that replies with an ephemeral message of voters for each choice
for anonymous polls, the number of people who voted for each choice is missing - can we also add the running count there as well?
for time-limited polls, let's also show the time remaining via a discord timestamp
I think it would be better to use components v2 for creating a poll (similar to how we do reaction redirect setup) than to accept the options via arguments, but this is okay to do in a separate PR

maybe-yiyi · 2026-04-21T02:47:14Z

Wait does this have ranked choice implemented

TenType

See the earlier comment

coderabbitai · 2026-06-29T17:59:01Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c3afe16b-5809-4bcc-9f05-dbc347d6522b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch polls

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Adds show_progress_bars and option_marker_style columns to both poll_config (guild-wide defaults) and polls (per-poll snapshot so behavior doesn't change retroactively if guild settings change later).

Moves poll configuration out of the generic SetupForm wizard into a dedicated buttons-in-a-container flow matching PollCreateForm's style, since a subcommand can't carry .setDefaultMemberPermissions() (only top-level slash commands can), and the new flow needs plain toggle buttons alongside a channel select rather than a form wizard. Lets admins configure: the polls channel, whether progress bars are shown, and whether option markers use letters or numbers.

- message_id options were passed straight into a bigint DB column; non-numeric input (e.g. 'a') threw a raw Postgres cast error instead of a clean reply. Added a snowflake regex check on every subcommand that takes a message_id. - Closing/deleting a poll required Administrator; weakened to ManageMessages, which better fits the action. - Added .orderBy(asc(pollOptions.id)) to option queries so option order is deterministic (Postgres doesn't guarantee row order without an ORDER BY). - Removed the /poll setup subcommand (moved to the standalone /pollsetup command) and pointed the "no polls channel configured" message at it.

pollCreateForm.ts: - Scale to 20 max options (was 10). - Replace push/pop-only option editing (Add option / Remove last) with a dedicated options sub-view where each option gets its own remove button, since Discord's 40-component-per-message cap rules out giving every option its own button alongside the rest of the form on the main view. - Fix Multi-select/Ranked choice toggle asymmetry: picking either one now always clears the other, instead of only one direction doing so. - Replace unconventional symbols (×, —, ·) with plain ASCII. - Guard each option-add modal with a per-call nonce in its customId so a double-triggered modal can't have two awaitModalSubmit listeners both resolve on the same submission (was double-adding options). - Scope the component collector to the reply message (not the whole channel) and track one active session per user per guild, canceling a user's previous /poll create session when they start a new one - concurrent sessions were cross-talking since the old channel-scoped collector reacted to interactions from either session. - Suppress notification pings from the poll message's mentions. - Wire up the new showProgressBars/optionMarkerStyle poll-setup options end to end. pollVotes.ts: - Convert the live/closed poll message from an embed to a Components V2 container so it can have a real separator (embeds have no native horizontal rule), restoring the divider under the title the reviewer asked for. - Add letter/number marker emoji beside each option and in the voting dropdown, stable regardless of vote-percentage sort order. - Render the options/bars as a monospaced table; labels are padded, never truncated. Labels longer than a cap move their bar/percentage to an indented line underneath instead of trailing inline, so a long option can't soft-wrap mid-row and strand the bar/percentage. - Bold the whitelist/blacklist line and move it out of the embed footer (footers can't render markdown), combined onto one small-text line with the timestamp. - Suppress notification pings on every send/edit/reply that can contain a mention. - .orderBy(asc(...)) on every option/vote query for deterministic ordering.

feat: add polls feature

d7d8fc9

ap-1 requested review from TenType and maybe-yiyi as code owners April 10, 2026 18:44

style: format drizzle snapshot

8d5531f

ap-1 marked this pull request as draft April 10, 2026 18:52

ap-1 self-assigned this Apr 10, 2026

ap-1 added 3 commits April 10, 2026 15:11

feat: add anonymous, role restrictions, and live voter display

7797020

feat: add timed polls, /poll close, and shared results logic

99e7164

fix: handle unawaited promises in poll expiry

d15bd1c

ap-1 marked this pull request as ready for review April 10, 2026 19:35

feat: improve poll UX and fix embed rendering

7531add

fix: use clear vote option instead of minValues for unvoting

dfed990

maybe-yiyi requested changes Apr 13, 2026

View reviewed changes

Comment thread src/commands/poll.ts Outdated

Comment thread src/commands/poll.ts Outdated

Comment thread src/commands/poll.ts Outdated

fix: poll embed limits and input validation

0986e0f

ap-1 requested a review from maybe-yiyi April 13, 2026 21:59

maybe-yiyi approved these changes Apr 13, 2026

View reviewed changes

TenType reviewed Apr 13, 2026

View reviewed changes

TenType reviewed Apr 14, 2026

View reviewed changes

TenType requested changes May 2, 2026

View reviewed changes

Gostmeaper self-assigned this May 3, 2026

Gostmeaper removed their assignment May 20, 2026

scottylabs-bot force-pushed the main branch from affe943 to 22b47e2 Compare June 15, 2026 02:54

ap-1 added 3 commits June 29, 2026 12:00

feat: add polls feature

b7f9e2c

style: format drizzle snapshot

5d20794

feat: add anonymous, role restrictions, and live voter display

8359bdf

ap-1 and others added 6 commits June 29, 2026 12:00

feat: add timed polls, /poll close, and shared results logic

749a893

fix: handle unawaited promises in poll expiry

f8a71d8

feat: improve poll UX and fix embed rendering

8c8c972

fix: use clear vote option instead of minValues for unvoting

086cb46

fix: poll embed limits and input validation

a87c642

feat: basic implementation of suggestions

430e95b

scottylabs-bot force-pushed the polls branch from 0986e0f to 430e95b Compare June 29, 2026 17:58

Gostmeaper added 3 commits June 29, 2026 14:16

fix: interaction create

424dc9b

fix: consistent progress bar lengths

141fc1c

fix: add ModalSubmitInteraction to imports

68e8ea7

scottylabs-bot force-pushed the polls branch from d035972 to d6137dd Compare July 4, 2026 22:29

Gostmeaper added 5 commits July 4, 2026 18:42

chore: bump devenv and flake lockfiles

1535d12

feat(db): add progress bar and option marker style poll settings

78993c4

Adds show_progress_bars and option_marker_style columns to both poll_config (guild-wide defaults) and polls (per-poll snapshot so behavior doesn't change retroactively if guild settings change later).

scottylabs-bot force-pushed the polls branch from 90aec24 to 932ae53 Compare July 4, 2026 23:09

Uh oh!

Conversation

ap-1 commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maybe-yiyi commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ap-1 commented Apr 13, 2026

Uh oh!

maybe-yiyi commented Apr 13, 2026

Uh oh!

ap-1 commented Apr 13, 2026

Uh oh!

maybe-yiyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maybe-yiyi left a comment

Choose a reason for hiding this comment

Uh oh!

TenType left a comment

Choose a reason for hiding this comment

Uh oh!

TenType left a comment

Choose a reason for hiding this comment

Uh oh!

maybe-yiyi commented Apr 21, 2026

Uh oh!

TenType left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ap-1 commented Apr 10, 2026 •

edited

Loading

maybe-yiyi commented Apr 13, 2026 •

edited

Loading

coderabbitai Bot commented Jun 29, 2026 •

edited

Loading