Merge Luke's SA-295 branch to improve onboarding screen behaviour#875
Merged
davecraig merged 29 commits intoScottish-Tech-Army:mainfrom Apr 21, 2026
Merged
Merge Luke's SA-295 branch to improve onboarding screen behaviour#875davecraig merged 29 commits intoScottish-Tech-Army:mainfrom
davecraig merged 29 commits intoScottish-Tech-Army:mainfrom
Conversation
…this on the first focusable composable. - Setting `focusable()` on the `Modifier` of the Composables that I want Talkback to read.
- `Added LaunchedEffect for previous screens to trigger focus request`
…viour seems to not need the `focusable()` modifier ALL the time.
- Added Tests to confirm some expected behaviour.
…atingScreenViewModel
- Need to check status of devices with SDK less than 33. Array of permissions contains Fine Location and Background Location but before my changes, only showed one rationale in the list. After my changes, shows 3. Aware of why this is, but need to check.
…en before tapping "Continue" - TODO: Discuss copy to make user aware and add to screen. - TODO: Disable Continue until permissions are granted. - TODO: Discuss "Background location" permission, copy and expected behaviour when/if denied.
…vigation from the BatteryOptimizationScreen.
…earer and not have logic within code to define how UI appears.
…kback to group them.
…issions are granted.
- Flipped filter predicate due to use of `all` returning true when empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.