SA-301 - List position lost when adding waypoints#865
Draft
lukeduncan-scot wants to merge 8 commits intoScottish-Tech-Army:mainfrom
Draft
SA-301 - List position lost when adding waypoints#865lukeduncan-scot wants to merge 8 commits intoScottish-Tech-Army:mainfrom
lukeduncan-scot wants to merge 8 commits intoScottish-Tech-Army:mainfrom
Conversation
…e object to help with debugging and enable greater testability.
- Exposed functions to replicate behaviour previously performed on exposed property.
- Tested on Pixel 9 Pro AVD.
lukeduncan-scot
temporarily deployed
to
development
GitHub Actions
Inactive
- Removed redundant remember key.
lukeduncan-scot
temporarily deployed
to
development
GitHub Actions
Inactive
lukeduncan-scot
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue (SA-301) that occurred when user selected POI and backed out, resetting list to top.
I had to perform some refactoring to chase down where the bug was, there is some line break changes that you might want reverted, if this is the case then please let me know.
The bug still appeared until - Set internalUiState as private to prevent external changes. where I made the UI state property private to prevent external classes from mutating it.
Any questions, feel free to ask.