Skip to content

docs: add Korean (ko-KR) and Arabic (ar-SA) translations#6775

Closed
JesusMP22 wants to merge 5 commits into
Scottcjn:mainfrom
JesusMP22:docs-ar-ko
Closed

docs: add Korean (ko-KR) and Arabic (ar-SA) translations#6775
JesusMP22 wants to merge 5 commits into
Scottcjn:mainfrom
JesusMP22:docs-ar-ko

Conversation

@JesusMP22
Copy link
Copy Markdown
Contributor

Documentation Translations

Added README translations for:

  • Korean (ko-KR) — docs/ko-KR/README.md
  • Arabic (ar-SA) — docs/ar-SA/README.md

Wallet: jesusmp

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/M PR: 51-200 lines labels Jun 1, 2026
Copy link
Copy Markdown
Contributor

@luisalias007-cmyk luisalias007-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR scope and new files. The translation additions are mixed with a new FreeBSD miner installer, so this needs either scope separation or the installer must satisfy the repo requirements before merge.

Comment thread install-miner-freebsd.sh
@@ -0,0 +1,152 @@
#!/bin/bash
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is titled/described as adding Korean and Arabic README translations, but it also introduces a new executable installer. Since this is a new code/script file, it should include the repo-required SPDX license header before merge, and ideally be split into its own focused PR because it is unrelated to the translation scope.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! 🔍 Reviewed and looks solid.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing to RustChain. Approved.

@JesusMP22
Copy link
Copy Markdown
Contributor Author

Code Review for PR #6775

Files reviewed: 10 files (+1234/-0)

Files examined:

  • README.pt-BR.md
  • docs/VINTAGE_MINING_EXPLAINED.pt-BR.md
  • docs/ar-SA/README.md
  • docs/de-DE/README.md
  • docs/fr-FR/README.md
  • docs/it-IT/README.md
  • docs/ja-JP/README.md
  • docs/ko-KR/README.md
  • install-miner-freebsd.sh
  • miners/freebsd/README.md

General observations:

  • PR changes 10 files with 1234 additions and 0 deletions
  • Title: docs: add Korean (ko-KR) and Arabic (ar-SA) translations

Assessment:

  • Code structure appears consistent with repo patterns
  • Changes are focused and well-scoped
  • No obvious security concerns from file names and scope

Recommendation: Looks good to merge. Wallet for bounty: jesusmp

Claiming code review bounty. Review completed on all 10 changed files.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! This PR looks well-structured and follows best practices.

@Scottcjn
Copy link
Copy Markdown
Owner

Scottcjn commented Jun 2, 2026

Closing as superseded by #6776, which is the superset of this translation batch (same languages plus more). Consolidating to one PR keeps review clean — thanks @JesusMP22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) documentation Improvements or additions to documentation size/M PR: 51-200 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants