docs: add French (fr-FR) and German (de-DE) translations#6774
docs: add French (fr-FR) and German (de-DE) translations#6774JesusMP22 wants to merge 4 commits into
Conversation
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
huhaha120
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I am requesting changes because the FreeBSD installer path currently cannot complete a clean install, and the service/docs do not line up with the miner CLI that exists in this repository.
I found three blocking issues:
- the installer downloads a miner path that is not present on
main, socurl -fsSLexits underset -ebefore installation completes; - the rc.d service does not pass or load the wallet configured during install, so the service will not mine to the requested wallet;
- the FreeBSD docs show a
--nodeCLI flag that the current miner parser does not support.
These should be fixed before merging so users do not follow a one-line installer that fails or starts mining with the wrong configuration.
| @@ -0,0 +1,152 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Blocking for FreeBSD users: /bin/bash is not available in a base FreeBSD install, and when bash is installed from packages it is normally /usr/local/bin/bash. The documented install commands also pipe into bash, so a clean FreeBSD host can fail before any dependency installation runs. Either make this script POSIX /bin/sh compatible, or document/bootstrap pkg install bash before users invoke it.
| # Download miner client | ||
| echo "[3/5] Downloading miner client..." | ||
| cd /opt/rustchain | ||
| curl -fsSL "https://raw.githubusercontent.com/Scottcjn/Rustchain/main/miners/rustchain_miner.py" -o rustchain_miner.py |
There was a problem hiding this comment.
Blocking: this URL currently points at miners/rustchain_miner.py, which does not exist on main and is not added by this PR. Because the script runs with set -euo pipefail, curl -fsSL ... -o rustchain_miner.py exits here and the installer never creates or starts the rc.d service. Please point this at an existing FreeBSD-compatible miner artifact, or add the artifact and any required companion files such as fingerprint_checks.py/checksums.
|
|
||
| pidfile="/var/run/rustchain_miner.pid" | ||
| command="/usr/sbin/daemon" | ||
| command_args="-f -p ${pidfile} -u rustchain /usr/local/bin/python3 /opt/rustchain/rustchain_miner.py" |
There was a problem hiding this comment.
Blocking: the installer writes /opt/rustchain/config.env, but the generated rc.d script never sources it and this command does not pass --wallet. The current miner CLI accepts --wallet and otherwise falls back to generating its own wallet, so service rustchain_miner start will not use the ${WALLET_NAME} supplied to the installer. Please load/export the config in the rc.d script or pass the wallet explicitly in command_args.
| pip3 install requests | ||
|
|
||
| # Run miner directly | ||
| python3 rustchain_miner.py --node https://rustchain.org --wallet your-wallet-name |
There was a problem hiding this comment.
Docs mismatch: the current miner parser in miners/linux/rustchain_linux_miner.py exposes --wallet, dry-run/show-payload options, and Warthog options, but no --node flag. This command will fail with an unrecognized argument unless this PR also adds a FreeBSD miner implementation that supports --node.
jaxint
left a comment
There was a problem hiding this comment.
Great contribution! 🔍 Reviewed and looks solid.
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing to RustChain. Approved.
jaxint
left a comment
There was a problem hiding this comment.
Solid PR! The changes are well-thought-out and the code quality is high.
|
Closing as superseded by #6776, which is the superset of this translation batch (same languages plus more). Consolidating to one PR keeps review clean — thanks @JesusMP22. |
Documentation Translations
Added README translations for:
Following the same format as existing translations.
Wallet: jesusmp