Skip to content

docs: add fr-FR miner localization pass#6756

Open
Ishant5436 wants to merge 2 commits into
Scottcjn:mainfrom
Ishant5436:localize-fr-FR
Open

docs: add fr-FR miner localization pass#6756
Ishant5436 wants to merge 2 commits into
Scottcjn:mainfrom
Ishant5436:localize-fr-FR

Conversation

@Ishant5436
Copy link
Copy Markdown

Summary

Adds a French (France) localization pass for the miner documentation and first-run consent strings for rustchain-bounties#12790.

Submission grammar

  • target_lang: fr-FR
  • files:
    • miners/linux/README.fr-FR.md
    • docs/fr-FR/RUSTCHAIN_EXPLAINED.md
    • i18n/fr-FR.json
  • glossary / terms-of-art kept literal:
    • RTC
    • attestation
    • antiquity
    • fingerprint

Acceptance notes

  • Consent strings require explicit affirmative input: OUI.
  • Verification commands are preserved literally: --dry-run, --show-payload, --test-only.
  • RUSTCHAIN_EXPLAINED cross-reference is included from the Linux miner README and links back to the French explainer.
  • No README badge/self-promo content is added.

Validation

  • python3 -m json.tool i18n/fr-FR.json
  • PYTHONIOENCODING=utf-8 python3 i18n/validate_i18n.py
  • git diff --cached --check

Requested payout: 10 RTC to canonical account github:Ishant5436.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) tests Test suite changes size/M PR: 51-200 lines labels Jun 1, 2026
@Scottcjn
Copy link
Copy Markdown
Owner

Scottcjn commented Jun 1, 2026

Thanks for the fr-FR localization pass. One blocker: this PR also adds tests/attractor_consensus_invariant_harness.py, which duplicates the consensus-invariant harness already submitted in #6773. Please split: keep only the fr-FR localization (i18n/fr-FR.json + docs) in this PR and drop the harness file — the harness is being evaluated under #6773. Once it's localization-only I'll merge.

Copy link
Copy Markdown
Contributor

@MolhamHamwi MolhamHamwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the fr-FR localization PR and the additional harness file.

Specific observations:

  • The fr-FR localization files preserve the required literal command flags (--dry-run, --show-payload, --test-only) and the consent gate remains explicit with affirmative: "OUI".
  • i18n/fr-FR.json validates structurally and keeps the key placeholders intact; python3 -m json.tool i18n/fr-FR.json and PYTHONIOENCODING=utf-8 python3 i18n/validate_i18n.py both passed locally.
  • The PR currently also adds tests/attractor_consensus_invariant_harness.py, which is unrelated to the fr-FR miner localization bounty described in the PR body. The harness tests pass locally (2 passed), but keeping it in this localization PR makes the submission scope mixed and may complicate maintainer acceptance for the one-language translation bounty.

I received RTC compensation for this review.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! 🔍 Reviewed and looks solid.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing to RustChain. Approved.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid PR! The changes are well-thought-out and the code quality is high.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing to RustChain. Approved.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) documentation Improvements or additions to documentation size/M PR: 51-200 lines tests Test suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants