docs: add fr-FR miner localization pass#6756
Conversation
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
|
Thanks for the fr-FR localization pass. One blocker: this PR also adds |
MolhamHamwi
left a comment
There was a problem hiding this comment.
Reviewed the fr-FR localization PR and the additional harness file.
Specific observations:
- The fr-FR localization files preserve the required literal command flags (
--dry-run,--show-payload,--test-only) and the consent gate remains explicit withaffirmative: "OUI". i18n/fr-FR.jsonvalidates structurally and keeps the key placeholders intact;python3 -m json.tool i18n/fr-FR.jsonandPYTHONIOENCODING=utf-8 python3 i18n/validate_i18n.pyboth passed locally.- The PR currently also adds
tests/attractor_consensus_invariant_harness.py, which is unrelated to the fr-FR miner localization bounty described in the PR body. The harness tests pass locally (2 passed), but keeping it in this localization PR makes the submission scope mixed and may complicate maintainer acceptance for the one-language translation bounty.
I received RTC compensation for this review.
jaxint
left a comment
There was a problem hiding this comment.
Great contribution! 🔍 Reviewed and looks solid.
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing to RustChain. Approved.
jaxint
left a comment
There was a problem hiding this comment.
Solid PR! The changes are well-thought-out and the code quality is high.
jaxint
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing to RustChain. Approved.
Summary
Adds a French (France) localization pass for the miner documentation and first-run consent strings for rustchain-bounties#12790.
Submission grammar
Acceptance notes
Validation
Requested payout: 10 RTC to canonical account github:Ishant5436.