Skip to content

fix: create persist files in pre_install #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rasa wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: create persist files in pre_install #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
090cebb
fix: create persist files in pre_install
rasa Jul 9, 2025
8d5e52f
fix: simplify pre_install commands
rasa Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,11 @@ def do_padfile(pad_name: str, pad_data: str, urls: Urls) -> Urls:
manifest.pop("architecture")
manifest["url"] = download
manifest["hash"] = hash32


manifest["pre_install"] = [
'if (-not (Test-Path \"$persist_dir/'+ name + '.cfg\")) { New-Item \"$dir/' +name + '.cfg\" -ItemType file | Out-Null }',
'if (-not (Test-Path \"$persist_dir/' + name + '_lng.ini\")) { New-Item \"$dir/' + name + '_lng.ini\" -ItemType file | Out-Null }',
]
# See https://github.com/ScoopInstaller/Nirsoft/issues/17
# See https://github.com/ScoopInstaller/Nirsoft/issues/46
password = PASSWORDS.get(name, '')
Expand All @@ -341,10 +345,8 @@ def do_padfile(pad_name: str, pad_data: str, urls: Urls) -> Urls:
manifest["architecture"]["32bit"]["url"] += "#dl.zip_"
else:
manifest["url"] += "#dl.zip_"
manifest["pre_install"] = [
r"$zip=(Get-ChildItem $dir\\" + name + "*).Name",
r"7z x $dir\\$zip -p'" + password + "' $('-o' + $dir) | Out-Null"
]
manifest["pre_install"].append('$zip=(Get-ChildItem $dir/' + name + '*).Name')
manifest["pre_install"].append('7z x $dir/$zip -p' + password + " $('-o' + $dir) | Out-Null")

rewrite_json(json_file, manifest)

Expand Down