dsc: Add version 3.1.1#6626
Conversation
|
Your changes do not pass checks. dsc
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. dsc
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. dsc
|
WalkthroughAdds a new Scoop manifest bucket/dsc.json for DSC v3.1.1, defining metadata, 64-bit and arm64 download URLs with hashes, bin mapping to dsc.exe, GitHub-based checkver, and architecture-aware autoupdate with versioned assets and hash extraction. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Scoop as Scoop (client)
participant GH as GitHub Releases
rect rgba(225,245,254,0.5)
Note over Scoop: Install/update flow for DSC
User->>Scoop: scoop install dsc / scoop update dsc
Scoop->>GH: Query latest release (checkver)
GH-->>Scoop: Latest tag/version
Scoop->>GH: Fetch asset URLs for x64/arm64
Scoop->>GH: Retrieve SHA256 (hash extraction)
Scoop-->>User: Download & install dsc.exe per arch
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Poem
✨ Finishing Touches🧪 Generate unit tests
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
bucket/dsc.json (2)
18-31: Autoupdate hash extraction is valid, but consider a tiny tweak.Your pattern works with GitHub’s release body. For consistency with Scoop docs, you can use the alias key "find" instead of "regex" (behavior is identical). Optional only. (github.com)
- "hash": { - "url": "https://github.com/PowerShell/DSC/releases/tag/v$version", - "regex": "(?s)$basename.*?$sha256" - } + "hash": { + "url": "https://github.com/PowerShell/DSC/releases/tag/v$version", + "find": "(?s)$basename.*?$sha256" + }
3-3: Trim description (style nit).Suggestion to make it crisper:
- "Cross‑platform CLI to manage software components declaratively and idempotently."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/dsc.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/dsc.json (4)
2-2: Version mismatch with PR title/summary.Manifest is 3.1.1 but PR title/summary say 3.1.0. Please align the PR title/description or pin the manifest to 3.1.0 (3.1.1 is the latest stable as of September 8, 2025). (newreleases.io)
8-14: URLs and hashes look correct for v3.1.1 (x86_64/arm64).Both download URLs resolve to the release assets, and the SHA256 values match the upstream release notes. (newreleases.io)
17-17: checkver is appropriate."checkver": "github" will track stable releases. No changes needed. (github.com)
16-16: Binary mapping correct as-is Verified thatdsc.exeresides at the archive root, so"bin": "dsc.exe"requires no change.
|
/verify |
|
All changes look good. Wait for review from human collaborators. dsc
|
1 participant
Closes #6625
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit