arduino@2.3.10: Switch to GitHub releases#18309
Conversation
📝 WalkthroughWalkthroughThe Arduino IDE manifest changes its Windows 64-bit download source from Arduino’s servers to GitHub Releases while retaining the existing hash. Version checking now uses GitHub, and autoupdate configuration generates a versioned GitHub Releases URL through the architecture-specific template. Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/arduino.json (1)
25-32: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueLocal testing guidance for manifest updates.
As a reminder for future updates, here are the standard instructions for testing the manifest locally before submission, as per path instructions:
- Optional: Enable debug mode and set GitHub token (to access GitHub API for releases only):
scoop config debug true scoop config gh_token <your-github-token> # Read access only- Force version detection and autoupdate:
.\bin\checkver.ps1 -App arduino -f- Auto-format (Lint) the JSON manifest:
.\bin\formatjson.ps1 -App arduino- Test installation for each architecture (if supported):
scoop install bucket\arduino.json -a 64bitFor further details on Scoop formatting and rules, refer to the Contribution Guide and App Manifests Wiki.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/arduino.json` around lines 25 - 32, For the manifest update involving the arduino autoupdate configuration, validate the changes locally by force-checking version detection with checkver.ps1, formatting with formatjson.ps1, and testing installation for the 64bit architecture; optionally enable Scoop debug mode and configure a read-only GitHub token for release API access.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/arduino.json`:
- Around line 25-32: For the manifest update involving the arduino autoupdate
configuration, validate the changes locally by force-checking version detection
with checkver.ps1, formatting with formatjson.ps1, and testing installation for
the 64bit architecture; optionally enable Scoop debug mode and configure a
read-only GitHub token for release API access.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a32fa9ad-dbd7-4605-bb77-ead509b2b1d0
📒 Files selected for processing (1)
bucket/arduino.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. arduino
|
z-Fng
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Downloads from GitHub releases are significantly faster than from downloads.arduino.cc.