markeron: Add version 1.5.1#18304
Conversation
📝 WalkthroughWalkthroughAdds a Scoop manifest for MarkerOn version 1.5.1. The manifest includes release metadata, a 64-bit installer URL and hash, a Windows pre-install cleanup command, a desktop shortcut, GitHub-based version checking, and autoupdate rules that construct the 64-bit release URL. Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
All changes look good. Wait for review from human collaborators. markeron
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/markeron.json (1)
1-35: 📐 Maintainability & Code Quality | 🔵 TrivialRun the required manifest checks before merging.
scoop config debug true scoop config gh_token <read-only-token> .\bin\checkver.ps1 -App markeron -f .\bin\formatjson.ps1 -App markeron scoop install .\bucket\markeron.json -a 64bit scoop update markeron scoop uninstall markeronSee the official Contribution Guide and App Manifests wiki. (github.com)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/markeron.json` around lines 1 - 35, Run the required Scoop manifest validation for markeron: enable debug mode and configure a read-only GitHub token, then execute checkver.ps1 and formatjson.ps1, followed by installing the 64-bit manifest, updating markeron, and uninstalling it. Resolve any reported validation, formatting, installation, or update issues before merging.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/markeron.json`:
- Line 14: Update the pre_install Remove-Item command in markeron.json to
tolerate absent wildcard matches by adding -ErrorAction SilentlyContinue or
guarding each target with Test-Path, while preserving the existing forced
recursive cleanup behavior for matching files.
---
Nitpick comments:
In `@bucket/markeron.json`:
- Around line 1-35: Run the required Scoop manifest validation for markeron:
enable debug mode and configure a read-only GitHub token, then execute
checkver.ps1 and formatjson.ps1, followed by installing the 64-bit manifest,
updating markeron, and uninstalling it. Resolve any reported validation,
formatting, installation, or update issues before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b763922c-5f0a-462b-bd3e-123b79d54716
📒 Files selected for processing (1)
bucket/markeron.json
| "license": { | ||
| "identifier": "MIT" | ||
| }, |
There was a problem hiding this comment.
| "license": { | |
| "identifier": "MIT" | |
| }, | |
| "license": "MIT", |
| }, | ||
| "hash": { | ||
| "url": "https://api.github.com/repos/ifer47/markeron/releases", | ||
| "jsonpath": "$..assets[?(@.browser_download_url == '$url')].digest" | ||
| } | ||
| } |
There was a problem hiding this comment.
| }, | |
| "hash": { | |
| "url": "https://api.github.com/repos/ifer47/markeron/releases", | |
| "jsonpath": "$..assets[?(@.browser_download_url == '$url')].digest" | |
| } | |
| } | |
| } | |
| } |
Updated JSON fields for consistency and added error handling in pre_install.
|
/verify |
|
All changes look good. Wait for review from human collaborators. markeron
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/markeron.json (1)
3-12: 📐 Maintainability & Code Quality | 🔵 TrivialValidate the manifest locally before submission.
Run the required Scoop checks and a 64-bit installation test:
.\bin\checkver.ps1 -App markeron -f .\bin\formatjson.ps1 -App markeron scoop install bucket/markeron.json -a 64bitOptionally enable debug mode and configure a read-only GitHub token for release checks.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/markeron.json` around lines 3 - 12, Validate the markeron manifest using the required checkver and formatjson commands, then perform a 64-bit installation test with scoop install. Fix any validation or installation issues before submission.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/markeron.json`:
- Around line 3-12: Validate the markeron manifest using the required checkver
and formatjson commands, then perform a 64-bit installation test with scoop
install. Fix any validation or installation issues before submission.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9a332c1f-056d-4e7c-84e0-af65a0f2efd4
📒 Files selected for processing (1)
bucket/markeron.json
ScoopInstaller/Scoop#6686 (comment)
|
2 participants
Closes #18299
I created an issue ( ScoopInstaller/Scoop#6686 ) because the default hash detection is not working as soon as I extend the download link with
#/dl.7z. Added anautoupdate.hashfor now.<manifest-name[@version]|chore>: <general summary of the pull request>