uniterm: Add version 1.4.1#18279
Conversation
📝 WalkthroughWalkthroughAdds a new Scoop manifest for Uniterm version 1.4.1. It defines package metadata, a proprietary license, 64-bit download URL and SHA256 checksum, the Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
the
package-request-needed
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/uniterm.json (1)
1-32: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPre-submission checklist: dependencies, persist, CRLF, and local testing.
A few items to verify before submission:
Dependencies: If uniterm requires .NET or Visual C++ Redistributable, declare them in a
suggestfield using standard Scoop identifiers (e.g.,"suggest": { "vcredist": "extras/vcredist2022" }).Persist data: If uniterm stores user settings/configurations in its install directory, add a
persistfield to preserve them across updates (e.g.,"persist": ["config"]).CRLF line endings: Scoop manifests must use CRLF line endings. Ensure this file uses CRLF before submission.
Local testing — run these before submitting:
# Optional: enable debug mode and GitHub token scoop config debug true scoop config gh_token <your-github-token> # Force version detection and autoupdate .\bin\checkver.ps1 -App uniterm -f # Auto-format (lint) the JSON manifest .\bin\formatjson.ps1 -App uniterm # Test installation scoop install .\bucket\uniterm.json -a 64bitWiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/uniterm.json` around lines 1 - 32, Before submission, verify uniterm’s runtime dependencies and add any required .NET or Visual C++ Redistributable packages under the manifest’s suggest field using standard Scoop identifiers; add persist entries if the application stores user data in its installation directory. Ensure bucket/uniterm.json uses CRLF line endings, then run checkver.ps1, formatjson.ps1, and a 64-bit local installation test to validate detection, formatting, and installation.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/uniterm.json`:
- Around line 1-32: Create and link a Scoop Extras package-request GitHub issue
for the new uniterm manifest, then reference its issue number or URL in the
manifest description or PR body. Before submitting, verify the uniterm project
satisfies the required acceptance criteria: at least 100 GitHub stars, a stable
non-pre-release release, and an English interface or documentation.
---
Nitpick comments:
In `@bucket/uniterm.json`:
- Around line 1-32: Before submission, verify uniterm’s runtime dependencies and
add any required .NET or Visual C++ Redistributable packages under the
manifest’s suggest field using standard Scoop identifiers; add persist entries
if the application stores user data in its installation directory. Ensure
bucket/uniterm.json uses CRLF line endings, then run checkver.ps1,
formatjson.ps1, and a 64-bit local installation test to validate detection,
formatting, and installation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 25816723-0c2f-4597-8495-a009be6114a0
📒 Files selected for processing (1)
bucket/uniterm.json
| { | ||
| "version": "1.4.1", | ||
| "description": "Lightweight all-in-one terminal emulator with built-in AI Agent", | ||
| "homepage": "https://uniterm.net", | ||
| "license": "Proprietary", | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://github.com/ys-ll/uniterm/releases/download/v1.4.1/uniterm-windows-amd64-portable-v1.4.1.zip", | ||
| "hash": "sha256:e14e1be6abf86ff79d431d9c964154fe5d59a2445d9f4093f0d9f211438225fd" | ||
| } | ||
| }, | ||
| "bin": "uniTerm.exe", | ||
| "shortcuts": [ | ||
| [ | ||
| "uniTerm.exe", | ||
| "uniTerm" | ||
| ] | ||
| ], | ||
| "checkver": { | ||
| "github": "https://github.com/ys-ll/uniterm" | ||
| }, | ||
| "autoupdate": { | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://github.com/ys-ll/uniterm/releases/download/v$version/uniterm-windows-amd64-portable-v$version.zip" | ||
| } | ||
| }, | ||
| "hash": { | ||
| "url": "$url.sha256" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Missing linked package request issue for new package.
This is a newly added manifest. Per the Scoop Extras contribution policy, new package requests must have a linked GitHub issue (e.g., #123 or an issue URL) in the description field or PR body. No such link was found in the PR.
Please create a package request issue using this link and reference it in the PR body:
https://github.com/ScoopInstaller/Extras/issues/new?labels=package-request&template=package-request.yml&title=%5BRequest%5D%3A+
Also ensure the package meets the acceptance criteria:
- Reasonably well-known and widely used (GitHub project should have at least 100 stars).
- A stable release available (not pre-release or alpha).
- English interface or at least English documentation.
Contribution guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/uniterm.json` around lines 1 - 32, Create and link a Scoop Extras
package-request GitHub issue for the new uniterm manifest, then reference its
issue number or URL in the manifest description or PR body. Before submitting,
verify the uniterm project satisfies the required acceptance criteria: at least
100 GitHub stars, a stable non-pre-release release, and an English interface or
documentation.
Source: Path instructions
aliesbelik
removed
the
package-request-needed
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with uniterm
|
3 participants
Lightweight all-in-one terminal emulator with built-in AI Agent.
Closes #18280