Skip to content

rebased@1.1.7: Fix executable name in bin, shortcuts and persist#18265

Merged
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
shiena:fix/rebased
Jul 12, 2026
Merged

rebased@1.1.7: Fix executable name in bin, shortcuts and persist#18265
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
shiena:fix/rebased

Conversation

@shiena

@shiena shiena commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

rename executable from "idea" to "rebased"

https://github.com/DetachHead/rebased/releases/tag/1.1.7

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This change updates the bucket/rebased.json installation manifest, replacing references to IDE\bin\idea64.exe with IDE\bin\rebased64.exe for the bin and shortcuts entries, and updating the persist list to use IDE\bin\rebased64.exe.vmoptions instead of IDE\bin\idea64.exe.vmoptions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific, concise, and matches the manifest update and executable rename in the changeset.
Description check ✅ Passed The description mostly matches the template, with a summary and checklist items filled in; the issue reference section is left blank.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/rebased.json (1)

24-36: 📐 Maintainability & Code Quality | 🔵 Trivial

Test the manifest locally before submission.

Before merging, validate the manifest with the following steps:

# Optional: enable debug mode and GitHub token for release API access
scoop config debug true
scoop config gh_token <your-github-token>  # Read access only

# Force version detection and autoupdate
.\bin\checkver.ps1 -App rebased -f

# Auto-format (lint) the JSON manifest
.\bin\formatjson.ps1 -App rebased

# Test installation for each architecture
scoop install bucket\rebased.json -a 64bit

Contribution guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests

As per path instructions, always test the manifest locally before submission.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/rebased.json` around lines 24 - 36, The rebased manifest needs to be
validated locally before submission; use the manifest’s existing app entries and
metadata in rebased.json to run checkver, formatjson, and an install test for
the supported architecture(s), then fix any issues found before resubmitting.
Make sure the manifest still passes Scoop validation after formatting and that
the rebased package artifacts referenced by the manifest install cleanly with
the current shortcut and persist settings.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/rebased.json`:
- Around line 24-36: The rebased manifest needs to be validated locally before
submission; use the manifest’s existing app entries and metadata in rebased.json
to run checkver, formatjson, and an install test for the supported
architecture(s), then fix any issues found before resubmitting. Make sure the
manifest still passes Scoop validation after formatting and that the rebased
package artifacts referenced by the manifest install cleanly with the current
shortcut and persist settings.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3ae941e4-af73-4632-98ee-4a650a36f375

📥 Commits

Reviewing files that changed from the base of the PR and between a9189fe and 1e155d3.

📒 Files selected for processing (1)
  • bucket/rebased.json

@shiena

shiena commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

rebased

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng
z-Fng merged commit 0cc1c9d into ScoopInstaller:master Jul 12, 2026
3 checks passed
@shiena
shiena deleted the fix/rebased branch July 12, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants