This repository was archived by the owner on Jan 16, 2020. It is now read-only.
Reading Legacy PK1 from PKXDelta / PikaSav#3
Open
ReignOfComputer wants to merge 4 commits into
Open
Conversation
Part 1 before I go to work. Todo TID and bits stuff.
Contributor
|
Wouldn't it be better to create a method that rearranges the data into the Rhydon pk1 format rather than having separate methods to handle loading? That would keep the conversion code separate from the loading code, plus you wouldn't duplicate the loading code. |
The more optimized route. No idea what 0x00, 0x02, and 0x24-0x2E are for though.
Author
|
Wasn't thinking, there we go :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.