Skip to content

virtio-net: log the device's features after vio_init #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanneve1 merged 1 commit into from
Oct 23, 2026
Merged

virtio-net: log the device's features after vio_init #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions xnu/files/bsd/dev/redwood_virtio_net.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,12 @@ virtio_net_start(uint8_t address[ETHER_ADDR_LEN])
printf("net: no virtio network device (QEMU: -device virtio-net-pci or virtio-net-device)\n");
return false;
}
offered = vio_device_features(net_dev);
if ((error = vio_init(net_dev, VIRTIO_BIT(VIRTIO_NET_F_MAC), &features)) != 0) {
printf("net: %s: features refused (the device offers %#llx)\n", vio_name(net_dev), offered);
printf("net: %s: features refused (the device offers %#llx)\n", vio_name(net_dev), vio_device_features(net_dev));
return false;
}
/* (read after vio_init: before it, a PCI device's registers may not be reachable yet, and read as all ones) */
offered = vio_device_features(net_dev);
if (!queue_make(&receive_queue, QUEUE_RECEIVE, true) || !queue_make(&transmit_queue, QUEUE_TRANSMIT, false)) {
vio_fail(net_dev);
return false;
Expand Down
Loading