Repository navigation
Refresh completed rerun results by ID during existing collections - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An older workflow run can pass after a rerun while its original creation time stays outside incremental polling. Refresh notified run IDs during the existing collection instead of adding another Actions-history scan or dispatch for each completion.
Companion bot: ScienceDiscovery/sciencediscovery_bot#23. The endpoint can be deployed first; unavailable endpoints leave ordinary collection running and pending hints remain at the bot.
Validation at
88b87055a24688a720f3558fd490193de65ec381:PYTHONDONTWRITEBYTECODE=1 TMPDIR="$PWD/.tmp" python3 -m unittest discover -s testsPYTHONDONTWRITEBYTECODE=1 python3 test/journey-rerun-collection.py; out-of-window failed run becomes green with its latest attempt and an atomic publication receiptnode .e2e/node_modules/playwright/cli.js test --config test/playwright.config.cjs; all dashboard journeys, including Real E2E marker geometry, carried/missing-score dashed lines and first-measurement boundariesThe journeys run the real collector/publisher process against a local HTTP stand-in and check the Git publication and post-publication receipt. No live collection was triggered.
The existing Real E2E curve journey still expected the pre-October-15
.score-failedmarker, a zero before the first measurement and a broken line across missing scores. Main already renders.score-xmarkers and dashed bridges after the first measured score. Update the regression assertions and documentation to this existing behavior, including marker coordinates, bridge geometry and missing-score explanations; production chart code and fixtures remain unchanged.