Repository navigation
Fix empty-input Dict{Any,Any} MethodError in wronskian - #557
Open
ChrisRackauckas-Claude wants to merge 2 commits into
Open
ChrisRackauckas-Claude wants to merge 2 commits into
ChrisRackauckas-Claude wants to merge 2 commits into
Conversation
When an ODE has no inputs, `Dict(u => rand(...) for u in u_vars)` infers
`Dict{Any,Any}` and misses the typed `power_series_solution` methods.
Annotate the three value dicts with the reduced ring's polynomial type.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dict(u => [rand(...)] for u in ode_red.u_vars)infersDict{Any,Any}(Julia cannot stabilize the generator when the key iterator is empty and the value usesrand).power_series_solutionmethods and breaksassess_identifiability/find_identifiable_functionsfor input-free models (including all Catalyst extension tests).P_red = eltype(ode_red.x_vars).Test plan
assess_identifiabilityon a Goodwin-like@ODEmodelwith no inputs succeeds locally after this change (previouslyMethodErroronpower_series_solution(..., Dict{Any,Any}, ...)).Unblocks SciML/Catalyst.jl#1525 Extensions CI.
Made with Cursor