Canonical CI: grouped-tests.yml + root test/test_groups.toml#27
Draft
ChrisRackauckas-Claude wants to merge 2 commits into
Draft
Canonical CI: grouped-tests.yml + root test/test_groups.toml#27ChrisRackauckas-Claude wants to merge 2 commits into
ChrisRackauckas-Claude wants to merge 2 commits into
Conversation
Convert the root test workflow (Tests.yml) to the canonical
grouped-tests.yml@v1 thin caller, with the group x version matrix declared
once in test/test_groups.toml.
- Tests.yml: replace the hand-maintained group x version matrix job with a
thin caller to SciML/.github/.github/workflows/grouped-tests.yml@v1
(on: + concurrency: preserved verbatim; all inputs default).
- test/test_groups.toml: [Core] on [lts, 1, pre]; [QA] on [lts, 1].
- Refactor inline QA: Aqua (previously inline in the Core group) and JET
(previously the `nopre` group) are consolidated into a QA group gated on
GROUP=="QA", isolated in test/qa/Project.toml ([sources] path to the root
package) + test/qa/qa.jl. runtests.jl activates+develops+instantiates the
qa env for the QA group. Functional tests stay in Core/All.
- Remove old test/qa.jl and test/nopre/.
- Drop Aqua from the root test/Project.toml (now isolated in test/qa).
Matrix preserved: old {Core: 1/lts/pre, nopre: 1/lts} -> new
{Core: lts/1/pre, QA: lts/1}; the `nopre` (JET) group becomes QA, which now
also runs Aqua. Linux-only, no os field.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The nopre -> QA consolidation in this branch removed test/nopre/ and added test/qa/Project.toml, but dependabot still pointed at the old directory, which would error once merged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root test workflow (
Tests.yml) to the canonicalgrouped-tests.yml@v1thin caller, with the group × version matrix declared once intest/test_groups.toml..github/workflows/Tests.yml: replaces the hand-maintainedgroup × versionmatrix job with a thin caller toSciML/.github/.github/workflows/grouped-tests.yml@v1.on:andconcurrency:are preserved verbatim. All reusable-workflow inputs use defaults (GROUP env, check-bounds, coverage), so nowith:block is needed. Linux-only (noosfield).test/test_groups.toml(new, repo root):[Core]on["lts","1","pre"];[QA]on["lts","1"].@safetestset "Quality Assurance" include("qa.jl")).nopregroup with its owntest/nopre/Project.toml.GROUP=="QA", isolated intest/qa/Project.toml(deps = Aqua + JET + LinearAlgebra + Test + the package via[sources]path = "../..",[compat] julia = "1.10") plustest/qa/qa.jl.runtests.jl, forGROUP=="QA", activatestest/qa, develops the root package, instantiates, then includesqa.jl. Functional tests (Constructors / Multiplication / Division / Interface) stay underCore(andAll).test/qa.jlandtest/nopre/; dropped Aqua from the roottest/Project.toml(now isolated intest/qa).Matrix match
Old matrix in
Tests.yml:version = [1, lts, pre],group = [Core, nopre], withexclude (pre, nopre){(Core,1), (Core,lts), (Core,pre), (nopre,1), (nopre,lts)}New matrix emitted by
compute_affected_sublibraries.jl --root-matrixfromtest/test_groups.toml:{(Core,lts), (Core,1), (Core,pre), (QA,lts), (QA,1)}The
nopre(JET) group becomesQAwith identical version coverage (lts,1);QAadditionally absorbs the Aqua check that was previously inline inCore. Same number of jobs, same version coverage, all onubuntu-latest. Verified statically by running the matrix-computation script against this branch; TOML and YAML parse confirmed.Notes
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code