Use SciMLTesting v1.0.0 (run_tests harness)#393
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
Replace the hand-written GROUP-dispatch in test/runtests.jl with a single SciMLTesting.run_tests call (v1.0.0), and add SciMLTesting to the test deps. Behavior-equivalent harness refactor; no test assertions or logic changed. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-package, multi-group (Core/Downstream/QA) shape with a standalone
test/Project.toml.corethunk runs the 8 Core safetestsets under All/Core.Downstreamran under both "All" and "Downstream" in the original, so it is an env-less self-activating thunk (callsactivate_group_env(test/downstream)inside the body, env undeclared) — keeping it in-process so it still runs under "All".QAran only forGROUP=="QA", so it declares itstest/qasub-env (excluded from "All"). The custom@test_brokenAqua/JET body inqa/qa.jlis preserved verbatim (not collapsed intorun_qa).Pkgremoved fromtest/Project.toml [deps](only the old harness used it). Thetest/qasub-env is left untouched.Minor, deliberate, documented refinement:
activate_group_envdevelops the repo into the qa env on Julia 1.10 too, so QA tools analyze the PR-branch source on the LTS (the original relied on[sources], which 1.10 ignores → registered release); on 1.11+ behavior is identical. See the inline comment inruntests.jl.Behavior-equivalent harness refactor: replace the hand-written
GROUP-dispatch intest/runtests.jlwith a singleSciMLTesting.run_testscall (SciMLTesting v1.0.0), and addSciMLTestingto the test dependencies. No test assertions or logic were changed.Verified locally:
TOML.parsefileon the edited Project.toml(s) confirmsSciMLTestingis in the test deps with the correct UUID, andPkgremoved where it was only used by the old harness.Meta.parseallon the newruntests.jlis clean (no error nodes).SciMLTestingv1.0.0 resolves from the registry alongside the existing test deps.run_testsgroup/qa argument shapes validate against SciMLTesting's internalGroupSpecnormalizer.This PR is a draft and should be ignored until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code