feat: Implement lazy evaluation flag for WOperator to optimize memory and computation#387
Open
swiatlowemnie333 wants to merge 1 commit into
Open
Conversation
Author
|
Yo so about that commit i did for WOperator in SciMLOperators i added a lazy flag cuz i needed it for optimising the feedback loop in the system. i changed the mutable struct WOperator so it stores a lazy::Bool and updated the constructor so its false by default so it dont break old code. also fixed the copy method so it transfers the state right. all 947 tests passed and are green so its working good and no errors. i think its realy needed to manage memory and not dump everything at once when not needed. Peace. |
Member
|
It doesn't seem to be used anywhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.