fix: propagate kwargs to remake_initialization_data#978
Open
vyudu wants to merge 1 commit into
Open
Conversation
AayushSabharwal
requested changes
Apr 1, 2025
AayushSabharwal
left a comment
AayushSabharwal
left a comment
Member
There was a problem hiding this comment.
This is breaking. The method in MTK doesn't have kwargs, so this will never dispatch to it.
Member
Author
|
Right yeah I change the MTK function here
SciML/ModelingToolkit.jl#3516
…On Tue, Apr 1, 2025 at 12:35 AM Aayush Sabharwal ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This is breaking. The method in MTK doesn't have kwargs, so this will
never dispatch to it.
—
Reply to this email directly, view it on GitHub
<#978 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANAOXYEANYIXJUZYNNSE7KL2XIJRDAVCNFSM6AAAAAB2FKUPUGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMZRGA4DOOJUGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
It's still breaking, because this version of SciMLBase won't work with older versions of MTK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.