Skip to content

fix nlprob to match the initialization system#860

Merged
ChrisRackauckas merged 11 commits into
SciML:masterfrom
oscardssmith:os/refactor-nlprob-to-nlprob_data
Nov 16, 2024
Merged

fix nlprob to match the initialization system#860
ChrisRackauckas merged 11 commits into
SciML:masterfrom
oscardssmith:os/refactor-nlprob-to-nlprob_data

Conversation

@oscardssmith

Copy link
Copy Markdown
Member

this adds the docs from #844 and adds all the extra pieces needed to make this the same as what the initialization system uses.

@ChrisRackauckas

Copy link
Copy Markdown
Member

it's not documented now?

@oscardssmith

Copy link
Copy Markdown
Member Author

I matched the initialization system

oscarddssmith added 2 commits November 13, 2024 13:35
@oscardssmith

Copy link
Copy Markdown
Member Author

oh @ChrisRackauckas, the reason you were confused is that I forgot to add the new file.

@ChrisRackauckas

Copy link
Copy Markdown
Member

no import?

@oscardssmith

Copy link
Copy Markdown
Member Author

fixed

Comment thread src/ODE_nlsolve.jl Outdated
Comment thread src/scimlfunctions.jl
@ChrisRackauckas

Copy link
Copy Markdown
Member

Issues with include order seen in tests.

@oscardssmith

Copy link
Copy Markdown
Member Author

yeah. the issue is that the fields can't be type restricted since there otherwise is no order the files can be ordered in that avoids circular dependency

@oscardssmith

Copy link
Copy Markdown
Member Author

this should work now.

Oscar Smith added 2 commits November 14, 2024 16:46
@oscardssmith

Copy link
Copy Markdown
Member Author

@ChrisRackauckas pretty sure all CI errors are very unrelated. Merge?

@ChrisRackauckas ChrisRackauckas merged commit 169d419 into SciML:master Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants