Fix calculate_ensemble_errors' error vector types.#787
Open
henhen724 wants to merge 2 commits into
Open
Conversation
5 tasks
| err_type = typeof(collect(u[1].errors)[1][2]) | ||
| errors = Dict{Symbol, Vector{err_type}}() #Should add type information | ||
| error_means = Dict{Symbol, err_type}() | ||
| error_medians = Dict{Symbol, err_type}() |
Member
There was a problem hiding this comment.
Won't you need to take the norm as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context explained in this PR: SciML/DiffEqDevTools.jl#145
"The current version of SciMLBase's calculate_ensemble_errors returns errors that have the same number type as the solution vector. So, for complex solutions it returns ComplexF64 type errors (with zero imaginary part) and then the plotter will refused to plot them."
I am having some precompilation errors with some of the test on my machine, so I was not able to run all tests. However, the change is so minor it is hard to imagine that it broke anything.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.