[WIP] Fix Ensemble indexing when output_func is used#607
Draft
SebastianM-C wants to merge 2 commits into
Draft
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #607 +/- ##
==========================================
- Coverage 39.96% 39.94% -0.02%
==========================================
Files 54 54
Lines 4076 4078 +2
==========================================
Hits 1629 1629
- Misses 2447 2449 +2 ☔ View full report in Codecov by Sentry. |
AayushSabharwal
left a comment
Member
There was a problem hiding this comment.
LGTM. Are these functions tested anywhere, in both cases (.u isa AbstractVectorOfArray and otherwise)?
Member
Author
|
There are still some cases to handle. As for tests, the recipes don't have any tests, I was thinking to ad some with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
output_funcis used, the resulting type insim.u[i]is no longer <:AbstractVectorOfArray, so we need to avoid assuming that like in #599, #602 and #604I was thinking of the following output functions as tests:
For the plot recipes I was thinking that we could test if no warnings are thrown by the
plotcalls. That should catch depwarns too and if there's any error in the recipes, the test would error.This PR is WIP and not yet ready.