make symbolic indexing return VectorOfArray#466
Open
oscardssmith wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 43.47% 49.90% +6.42%
==========================================
Files 47 47
Lines 3558 3561 +3
==========================================
+ Hits 1547 1777 +230
+ Misses 2011 1784 -227
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
test? |
Member
Author
|
I think this is ready to go. |
| end | ||
| elseif i isa Base.Integer || i isa AbstractRange || i isa AbstractVector{<:Base.Integer} | ||
| A[i, :] | ||
| VectorOfArray(A[i, :]) |
Member
There was a problem hiding this comment.
how do you know this is a vector of arrays?
Member
|
tests are failing. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fairly minor change that makes things work more as expected.