overload 2 arg show for probs and sols#465
Conversation
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 43.47% 51.45% +7.97%
==========================================
Files 47 47
Lines 3558 3564 +6
==========================================
+ Hits 1547 1834 +287
+ Misses 2011 1730 -281
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| type_color, isinplace(prob), | ||
| no_color) | ||
| end | ||
| Base.show(io::IO, A::AbstractSciMLProblem) = show(io, MIME"text/plain", A) |
There was a problem hiding this comment.
I think this pretty much goes against the default and expected behaviour of show, see eg https://docs.julialang.org/en/v1/manual/types/#man-custom-pretty-printing. The two args method should print a compact one-line representation.
There was a problem hiding this comment.
You are right. The 2 arg version shouldn't have the line breaks. I'll take another pass on this tomorrow (that also removes the redundancy of all the show methods.)
|
So this should close? |
|
No. I'm planning on updating this today so that the 2 argument version prints a compact view (but moved onto 1 line). |
3 participants
@ChrisRackauckas thinks this might break things, but I want to appeal to CI. This makes it so SCIMLProblems and soltuions print nicely when they are within other structs.