Repository navigation
Avoid collisions with the RGF argument binding - #148
Merged
Merged
Conversation
Member
Author
|
Implementation log for commit
Local results:
Next step: monitor the full GitHub Actions matrix and address any failures. |
Member
Author
|
CI complete at d453982: all 16 checks passed, including Julia LTS, current, and pre-release on Linux, macOS, and Windows, plus QA, downgrade, documentation, Runic, Runic suggestions, spellcheck, and test-matrix detection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #147. Replace the generated wrapper's ASCII
__argsbinding with the deterministic package-specific identifierˍ₋rgf₋args.This preserves deterministic generated source without a per-module gensym while making accidental capture of a user-defined
__argsfunction negligible.Regression
Restore the
__argsMRE documented in #146. It fails on the mergedmasterby attempting to call the argument tuple and passes with this change.The fixed identifier is collision avoidance rather than complete hygiene: code that deliberately uses the exact name
ˍ₋rgf₋argscan still collide.Verification
fand__argscollision regressionsjulia --startup-file=no --project=. -e 'using Pkg; Pkg.activate("."); Pkg.test()'--check --diff --verboseover all 10 tracked Julia filesChecklist