Repository navigation
Avoid specializing drop_expr on concrete RGF types - #144
Merged
ChrisRackauckas merged 1 commit intoAug 20, 2026
Merged
Conversation
Extract the type parameters behind a specialization barrier and retain the current thread-safe cache accessors. Add a trace-compile regression test covering many distinct RGF types. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
This supersedes #123, whose contributor-fork head cannot be updated by the currently authenticated account. The commit retains Kristoffer Carlsson as author.
drop_exprpreviously specialized on every concreteRuntimeGeneratedFunctiontype, including its expression ID, compiling a new method instance for each generated function. This adds a specialization barrier, extracts the required type parameters through small helpers, and preserves the current thread-safe_BodyCacheaccessors.Regression evidence
Unfixed
master, with the new test applied:The same command with this fix:
Verification
Not verified locally
Reviewer judgment call
The regression test uses Julias documented
--trace-compileCLI output in a fresh subprocess and asserts that calls over 20 distinct RGF types emit no concretedrop_exprprecompile statements. This directly detects the compilation blow-up without relying on private compiler-introspection APIs.Ignore this PR until it has been reviewed by @ChrisRackauckas.